Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1318543005: Fix relayout-fixed-position-after-scale.html to work with virtual-viewport. (Closed)

Created:
5 years, 4 months ago by bokan
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix relayout-fixed-position-after-scale.html to work with virtual-viewport. This test was using removed internal methods and didn't set a minimum page scale which is now needed for position-fixed elements to correctly get their percentage based size. BUG=225184 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/relayout-fixed-position-after-scale.html View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bokan
5 years, 4 months ago (2015-08-25 18:37:38 UTC) #2
aelias_OOO_until_Jul13
lgtm
5 years, 4 months ago (2015-08-25 18:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318543005/1
5 years, 4 months ago (2015-08-25 18:50:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104077)
5 years, 4 months ago (2015-08-25 19:19:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318543005/1
5 years, 4 months ago (2015-08-25 20:07:04 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 20:41:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201149

Powered by Google App Engine
This is Rietveld 408576698