Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 131853012: [NaCl SDK] Always set cross compiler with building arm components. (Closed)

Created:
6 years, 10 months ago by Sam Clegg
Modified:
6 years, 9 months ago
Reviewers:
noelallen1
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCl SDK] Set ARM cross compiler with building ARM components using gyp. R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
This change will pass on the linux sdk builder if and only if the arm ...
6 years, 10 months ago (2014-02-11 23:45:14 UTC) #1
Sam Clegg
Noel, PTAL.
6 years, 9 months ago (2014-03-07 17:43:24 UTC) #2
Sam Clegg
The CQ bit was checked by sbc@chromium.org
6 years, 9 months ago (2014-03-07 21:10:53 UTC) #3
Sam Clegg
The CQ bit was unchecked by sbc@chromium.org
6 years, 9 months ago (2014-03-07 21:10:58 UTC) #4
noelallen1
lgtm
6 years, 9 months ago (2014-03-07 21:19:16 UTC) #5
Sam Clegg
6 years, 9 months ago (2014-03-07 23:27:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r255712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698