Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/code_patcher_ia32.cc

Issue 131853006: Fix debugger stub patching on x64 architecture (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher_arm.cc ('k') | runtime/vm/code_patcher_mips.cc » ('j') | runtime/vm/code_patcher_x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_ia32.cc
===================================================================
--- runtime/vm/code_patcher_ia32.cc (revision 31757)
+++ runtime/vm/code_patcher_ia32.cc (working copy)
@@ -220,7 +220,17 @@
}
+uint32_t CodePatcher::GetPoolOffsetAt(uword return_address) {
+ UNIMPLEMENTED();
Ivan Posva 2014/01/14 22:12:39 This should be UNREACHABLE() as the ia32 assembler
hausner 2014/01/14 22:49:41 Done.
+ return 0;
+}
+
+void CodePatcher::SetPoolOffsetAt(uword return_address, uint32_t offset) {
+ UNIMPLEMENTED();
Ivan Posva 2014/01/14 22:12:39 ditto
hausner 2014/01/14 22:49:41 Done.
+}
+
+
void CodePatcher::InsertCallAt(uword start, uword target) {
// The inserted call should not overlap the lazy deopt jump code.
ASSERT(start + CallPattern::InstructionLength() <= target);
« no previous file with comments | « runtime/vm/code_patcher_arm.cc ('k') | runtime/vm/code_patcher_mips.cc » ('j') | runtime/vm/code_patcher_x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698