Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 131853005: Merge 244295 "Ensure that trackpad and trackpoint scrolling work..." (Closed)

Created:
6 years, 11 months ago by ananta
Modified:
6 years, 11 months ago
Reviewers:
ananta
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, ben+views_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Merge 244295 "Ensure that trackpad and trackpoint scrolling work..." > Ensure that trackpad and trackpoint scrolling works on Windows desktop Aura with legacy trackpad drivers. > > Legacy trackpad drivers like the older synaptics drivers have bugs where in they don't generate the WM_MOUSEWHEEL > messages for applications unless there is an entry for the application with the class name of the window in their > config file. If an entry does not exist here, these drivers expect the window to have the WS_VSCROLL/WS_HSCROLL style > to generate the legacy WM_VSCROLL/WM_HSCROLL messages. > > This patch adds these styles to top level windows for Windows Aura. To ensure that Windows does not draw these > scrollbars, we hide them when the window size changes and readd them in a posted task which works correctly in our > testing. > > Changes in this patch are as below:- > 1. Add handlers to the HWNDMessageHandler class for the WM_VSCROLL/WM_HSCROLL messages. > 2. Forward the scroll events to the HWNDMessageHandlerDelegate which then forwards it off to its delegate. > 3. Miscellaneous fixes in the events code to allow the WM_VSCROLL/WM_HSCROLL messages to go through. > > BUG=320849 > R=cpu@chromium.org, sky@chromium.org, cpu, sky > > Review URL: https://codereview.chromium.org/133053004 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/win/events_win.cc View 4 chunks +22 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.h View 3 chunks +8 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 5 chunks +61 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
6 years, 11 months ago (2014-01-11 01:48:53 UTC) #1
ananta
6 years, 11 months ago (2014-01-11 01:49:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r244298.

Powered by Google App Engine
This is Rietveld 408576698