Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/resources/options/password_manager_list.css

Issue 1318523011: [Password Manager] Copiable username and origin. Linkable origin elided from the left. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Copiable username and origin in css. Linkable origin elided from the left. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/password_manager_list.css
diff --git a/chrome/browser/resources/options/password_manager_list.css b/chrome/browser/resources/options/password_manager_list.css
index ee17a12d31e1b2aefc5bcd8b00308be0733ae10d..c695d1216bba0fa3da6963782ad6c4ed3472e656 100644
--- a/chrome/browser/resources/options/password_manager_list.css
+++ b/chrome/browser/resources/options/password_manager_list.css
@@ -22,7 +22,8 @@ html[dir='rtl'] #saved-passwords-list .list-inline-button {
left: 2px;
}
-input[type='password'].inactive-password {
+input[type='password'].inactive-item,
+input[type='text'].inactive-item {
background: transparent;
border: none;
}
@@ -37,6 +38,11 @@ input[type='password'].inactive-password {
width: 30%;
}
+#saved-passwords-list .url,
+#saved-passwords-list .name {
+ -webkit-user-select: text;
+}
+
#saved-passwords-list .password,
#saved-passwords-list .federation {
-webkit-box-flex: 1;
@@ -61,3 +67,14 @@ input[type='password'].inactive-password {
overflow: hidden;
text-overflow: ellipsis;
}
+
+#saved-passwords-list .left-elided-url,
Evan Stade 2015/09/29 18:06:52 can you just do .left-elided-url{...}?
kolos1 2015/09/29 18:29:01 Done.
+#password-exceptions-list .left-elided-url {
+ -webkit-margin-start: 0;
+ -webkit-padding-start: 3px;
+ direction: rtl;
Evan Stade 2015/09/29 18:06:52 I must be totally misunderstanding this class beca
kolos1 2015/09/29 18:29:01 This class elide urls (without scheme and path) fr
Evan Stade 2015/09/29 18:53:07 I see. So this is a big hack and needs a lot of do
kolos1 2015/10/05 18:43:22 Yes, I tested with RTL and LTR locales. Now it wor
+ margin-left: 7px;
+ padding-left: 26px;
Evan Stade 2015/09/29 18:06:53 why do you have padding-left as well as -webkit-pa
kolos1 2015/10/05 18:43:22 For LTR: since the direction is changed, the icon
+ text-align: left;
Evan Stade 2015/09/29 18:06:52 why do you want to left align for RTL? the omnibox
Evan Stade 2015/09/29 18:53:07 I still suspect this is the wrong text-align for R
kolos1 2015/10/05 18:43:23 Right. It should be only for LTR. Fixed.
+ unicode-bidi: bidi-override;
+}

Powered by Google App Engine
This is Rietveld 408576698