Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3999)

Unified Diff: chrome/browser/ui/webui/large_icon_source.h

Issue 1318523011: [Password Manager] Copiable username and origin. Linkable origin elided from the left. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Icons appearance fixed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/large_icon_source.h
diff --git a/chrome/browser/ui/webui/large_icon_source.h b/chrome/browser/ui/webui/large_icon_source.h
index fb573ea45f6d63a76843bc80e10925dacf663775..55bd014db75c2dcadeeacf7b0d8c6bd402147a81 100644
--- a/chrome/browser/ui/webui/large_icon_source.h
+++ b/chrome/browser/ui/webui/large_icon_source.h
@@ -25,15 +25,24 @@ struct LargeIconResult;
//
// Format:
// chrome://large-icon/size/url
+// or
+// chrome://large-icon/size/fallback/fallback_params/url
//
// Parameter:
// 'size' Required (including trailing '/')
// Positive integer to specify the large icon's size in pixels.
+// fallback_params Optional
+// 5 comma-separated parameters of fallback icon in the format described at
+// the top of the file "chrome/browser/ui/webui/fallback_icon_source.h".
// 'url' Optional
// String to specify the page URL of the large icon.
//
-// Example: chrome://large-icon/48/http://www.google.com/
-// This requests a 48x48 large icon for http://www.google.com.
+// Examples:
+// chrome://large-icon/48/http://www.google.com/
+// This requests a 48x48 large icon for http://www.google.com.
+// chrome://large-icon/16/fallback/,777,FFF,0.625,0.4/http://example.com
Evan Stade 2015/10/15 23:46:32 I don't think you should be passing this fallback
kolos1 2015/10/16 14:19:25 Thanks. That is very interesting idea, but what if
+// If there is no icon for example.com, the style of fallback icon will be
+// specified with listed parameters.
class LargeIconSource : public content::URLDataSource {
public:
// |fallback_icon_service| and |large_icon_service| are owned by caller and

Powered by Google App Engine
This is Rietveld 408576698