[Password Manager] Copiable username and origin. Linkable origin elided from the left.

chrome/browser/ui/webui/options/password_manager_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/password_manager_handler.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #if defined(OS_WIN) && defined(USE_ASH)
 #include "chrome/browser/ui/ash/ash_util.h"
 #endif
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/affiliation_utils.h"
 #include "components/password_manager/core/browser/password_bubble_experiment.h"
 #include "components/password_manager/core/common/experiments.h"
+#include "components/url_formatter/url_formatter.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/content_switches.h"
+#include "content/public/common/origin_util.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace options {
 
+namespace {
+// The following constants should be synchronized with the constants in
+// chrome/browser/resources/options/password_manager_list.js.
+const char kOriginField[] = "origin";

[Evan Stade, 2015/10/13 17:15:01]

ditto, not much use for these if you refactor/share more code below.

[kolos1, 2015/10/15 09:34:53]

I would like to have it. It gives explicit description what we pass from C++
part to Javascript part.

+const char kShownUrlField[] = "shownUrl";
+const char kIsSecureField[] = "isSecure";
+const char kUsernameField[] = "username";
+const char kPasswordField[] = "password";
+const char kFederationField[] = "federation";
+}
+
 PasswordManagerHandler::PasswordManagerHandler()
     : password_manager_presenter_(this) {}
 
 PasswordManagerHandler::~PasswordManagerHandler() {}
 
 Profile* PasswordManagerHandler::GetProfile() {
   return Profile::FromWebUI(web_ui());
 }
 
 #if !defined(OS_ANDROID)
 gfx::NativeWindow PasswordManagerHandler::GetNativeWindow() const {
   return web_ui()->GetWebContents()->GetTopLevelNativeWindow();
 }
 #endif
 
 void PasswordManagerHandler::GetLocalizedValues(
     base::DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
 
   static const OptionsStringResource resources[] = {
-    { "autoSigninTitle",
-      IDS_PASSWORDS_AUTO_SIGNIN_TITLE },
-    { "autoSigninDescription",
-      IDS_PASSWORDS_AUTO_SIGNIN_DESCRIPTION },
-    { "savedPasswordsTitle",
-      IDS_PASSWORDS_SHOW_PASSWORDS_TAB_TITLE },
-    { "passwordExceptionsTitle",
-      IDS_PASSWORDS_EXCEPTIONS_TAB_TITLE },
-    { "passwordSearchPlaceholder",
-      IDS_PASSWORDS_PAGE_SEARCH_PASSWORDS },
-    { "passwordShowButton",
-      IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON },
-    { "passwordHideButton",
-      IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON },
-    { "passwordsNoPasswordsDescription",
-      IDS_PASSWORDS_PAGE_VIEW_NO_PASSWORDS_DESCRIPTION },
-    { "passwordsNoExceptionsDescription",
-      IDS_PASSWORDS_PAGE_VIEW_NO_EXCEPTIONS_DESCRIPTION },
+      {"autoSigninTitle", IDS_PASSWORDS_AUTO_SIGNIN_TITLE},
+      {"autoSigninDescription", IDS_PASSWORDS_AUTO_SIGNIN_DESCRIPTION},
+      {"savedPasswordsTitle", IDS_PASSWORDS_SHOW_PASSWORDS_TAB_TITLE},
+      {"passwordExceptionsTitle", IDS_PASSWORDS_EXCEPTIONS_TAB_TITLE},
+      {"passwordSearchPlaceholder", IDS_PASSWORDS_PAGE_SEARCH_PASSWORDS},
+      {"passwordShowButton", IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON},
+      {"passwordHideButton", IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON},
+      {"passwordsNoPasswordsDescription",
+       IDS_PASSWORDS_PAGE_VIEW_NO_PASSWORDS_DESCRIPTION},
+      {"passwordsNoExceptionsDescription",
+       IDS_PASSWORDS_PAGE_VIEW_NO_EXCEPTIONS_DESCRIPTION},
   };
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
 
   const ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(GetProfile());
   int title_id =
-      password_bubble_experiment::IsSmartLockBrandingEnabled(sync_service) ?
-      IDS_PASSWORD_MANAGER_SMART_LOCK_FOR_PASSWORDS :
-      IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE;
+      password_bubble_experiment::IsSmartLockBrandingEnabled(sync_service)
+          ? IDS_PASSWORD_MANAGER_SMART_LOCK_FOR_PASSWORDS
+          : IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE;
   RegisterTitle(localized_strings, "passwordsPage", title_id);
 
   localized_strings->SetString("passwordManagerLearnMoreURL",
                                chrome::kPasswordManagerLearnMoreURL);
   localized_strings->SetString("passwordsManagePasswordsLink",
                                chrome::kPasswordManagerAccountDashboardURL);
 
   std::string management_hostname =
       GURL(chrome::kPasswordManagerAccountDashboardURL).host();
   base::string16 link_text = base::UTF8ToUTF16(management_hostname);
@@ skipping 102 matching lines @@
   password_manager_presenter_.UpdatePasswordLists();
 }
 
 void PasswordManagerHandler::SetPasswordList(
     const ScopedVector<autofill::PasswordForm>& password_list,
     bool show_passwords) {
   base::ListValue entries;
   languages_ = GetProfile()->GetPrefs()->GetString(prefs::kAcceptLanguages);
   base::string16 placeholder(base::ASCIIToUTF16("        "));
   for (size_t i = 0; i < password_list.size(); ++i) {
-    base::ListValue* entry = new base::ListValue();
-    entry->AppendString(password_manager::GetHumanReadableOrigin(
-        *password_list[i], languages_));
-    entry->AppendString(password_list[i]->username_value);
+    scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue);
+
+    entry->SetString(kOriginField,
+                     url_formatter::FormatUrl(
+                         password_list[i]->origin, languages_,
+                         url_formatter::kFormatUrlOmitNothing,
+                         net::UnescapeRule::SPACES, nullptr, nullptr, nullptr));
+
+    entry->SetString(kShownUrlField, password_manager::GetShownOrigin(
+                                         password_list[i]->origin, languages_));
+    entry->SetBoolean(kIsSecureField,
+                      content::IsOriginSecure(password_list[i]->origin));
+    entry->SetString(kUsernameField, password_list[i]->username_value);
     if (show_passwords) {
-      entry->AppendString(password_list[i]->password_value);
+      entry->SetString(kPasswordField, password_list[i]->password_value);
     } else {
       // Use a placeholder value with the same length as the password.
-      entry->AppendString(
+      entry->SetString(
+          kPasswordField,
           base::string16(password_list[i]->password_value.length(), ' '));
     }
     const GURL& federation_url = password_list[i]->federation_url;
     if (!federation_url.is_empty()) {
-      entry->AppendString(l10n_util::GetStringFUTF16(
-          IDS_PASSWORDS_VIA_FEDERATION,
-          base::UTF8ToUTF16(federation_url.host())));
+      entry->SetString(
+          kFederationField,
+          l10n_util::GetStringFUTF16(IDS_PASSWORDS_VIA_FEDERATION,
+                                     base::UTF8ToUTF16(federation_url.host())));
     }
-    entries.Append(entry);
+
+    entries.Append(entry.release());
   }
 
   web_ui()->CallJavascriptFunction("PasswordManager.setSavedPasswordsList",
                                    entries);
 }
 
 void PasswordManagerHandler::SetPasswordExceptionList(

[Evan Stade, 2015/10/13 17:15:01]

it seems like there's a lot of overlap here and in SetPasswordList

[kolos1, 2015/10/15 09:34:53]

Done. Thanks.

     const ScopedVector<autofill::PasswordForm>& password_exception_list) {
   base::ListValue entries;
   for (size_t i = 0; i < password_exception_list.size(); ++i) {

[Evan Stade, 2015/10/13 17:15:01]

for (const autofill::PasswordForm& exception : password_exception_list) {

}

[kolos1, 2015/10/15 09:34:54]

Done. Thanks

-    entries.AppendString(password_manager::GetHumanReadableOrigin(
-        *password_exception_list[i], languages_));
+    scoped_ptr<base::DictionaryValue> entry(new base::DictionaryValue);
+
+    entry->SetString(kOriginField,
+                     url_formatter::FormatUrl(
+                         password_exception_list[i]->origin, languages_,
+                         url_formatter::kFormatUrlOmitNothing,
+                         net::UnescapeRule::SPACES, nullptr, nullptr, nullptr));
+    entry->SetString(kShownUrlField,
+                     password_manager::GetShownOrigin(
+                         password_exception_list[i]->origin, languages_));
+    entry->SetBoolean(kIsSecureField, content::IsOriginSecure(
+                                          password_exception_list[i]->origin));
+
+    entries.Append(entry.release());
   }
 
   web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList",
                                    entries);
 }
 
 }  // namespace options