[Password Manager] Copiable username and origin. Linkable origin elided from the left.

chrome/browser/resources/options/password_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /////////////////////////////////////////////////////////////////////////////
@@ skipping 157 matching lines @@
      * Updates the data model for the saved passwords list with the values from
      * |entries|.
      * @param {!Array} entries The list of saved password data.
      */
     setSavedPasswordsList_: function(entries) {
       if (this.lastQuery_) {
         // Implement password searching here in javascript, rather than in C++.
         // The number of saved passwords shouldn't be too big for us to handle.
         var query = this.lastQuery_;
         var filter = function(entry, index, list) {
-          // Search both URL and username.
-          if (entry[0].toLowerCase().indexOf(query.toLowerCase()) >= 0 ||
-              entry[1].toLowerCase().indexOf(query.toLowerCase()) >= 0) {
+          // Search both shown URL and username.
+          var shownUrl = entry[options.passwordManager.SHOWN_URL_DATA_INDEX];
+          var username = entry[options.passwordManager.USERNAME_DATA_INDEX];
+          if (shownUrl.toLowerCase().indexOf(query.toLowerCase()) >= 0 ||
+              username.toLowerCase().indexOf(query.toLowerCase()) >= 0) {
             // Keep the original index so we can delete correctly. See also
             // deleteItemAtIndex() in password_manager_list.js that uses this.
-            entry[4] = index;
+            entry[options.passwordManager.ORIGINAL_DATA_INDEX] = index;
             return true;
           }
           return false;
         };
         entries = entries.filter(filter);
       }
       this.savedPasswordsList_.dataModel = new ArrayDataModel(entries);
       this.updateListVisibility_(this.savedPasswordsList_);
     },
 
@@ skipping 13 matching lines @@
      * @param {number} index The original index of the entry in the model.
      * @param {string} password The saved password.
      */
     showPassword_: function(index, password) {
       var model = this.savedPasswordsList_.dataModel;
       if (this.lastQuery_) {
         // When a filter is active, |index| does not represent the current
         // index in the model, but each entry stores its original index, so
         // we can find the item using a linear search.
         for (var i = 0; i < model.length; ++i) {
-          if (model.item(i)[4] == index) {
+          if (model.item(i)[options.passwordManager.ORIGINAL_DATA_INDEX] ==

[Evan Stade, 2015/10/05 18:59:41]

The item should be changed to a dict (js object) and then you can reference by
name (hardcoded string is fine in this case).

[kolos1, 2015/10/06 18:52:32]

Done.

+              index) {
             index = i;
             break;
           }
         }
       }
 
       // Reveal the password in the UI.
       var item = this.savedPasswordsList_.getListItemByIndex(index);
       item.showPassword(password);
     },
@@ skipping 36 matching lines @@
     'setPasswordExceptionsList',
     'showPassword'
   ]);
 
   // Export
   return {
     PasswordManager: PasswordManager
   };
 
 });