Remove |requestor_url| from ApplicationManager::ConnectToApplication().

mojo/shell/application_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SHELL_APPLICATION_MANAGER_H_
 #define MOJO_SHELL_APPLICATION_MANAGER_H_
 
 #include <map>
 
 #include "base/macros.h"
@@ skipping 66 matching lines @@
     DISALLOW_COPY_AND_ASSIGN(TestAPI);
   };
 
   explicit ApplicationManager(Delegate* delegate);
   ~ApplicationManager();
 
   // Loads a service if necessary and establishes a new client connection.
   // |originator| can be NULL (e.g. for the first application or in tests), but
   // typically is non-NULL and identifies the instance initiating the
   // connection.
-  // TODO(yzshen): Remove |requestor_url|.
+  // Please see the comments in connect_to_application_params.h for more details
+  // about the parameters.
   void ConnectToApplication(
       ApplicationInstance* originator,
-      URLRequestPtr requested_url,
+      URLRequestPtr app_url_request,

[sky, 2015/09/03 19:48:52]

I think requested_url is more descriptive.

[yzshen1, 2015/09/03 19:52:58]

I tried to use exactly the same names as the fields in
ConnectToApplicationParams.

In Params, we have |app_url| (GURL) and the corresponding |app_url_request|
(URLRequestPtr).

If we use |requested_url| in place of |app_url|, it seems awkward to change
|app_url_request| to |requestd_url_request|. What do you think? Thanks!

[sky, 2015/09/03 19:58:18]

You are right, sounds good.

       const std::string& qualifier,
-      const GURL& requestor_url,
       InterfaceRequest<ServiceProvider> services,
       ServiceProviderPtr exposed_services,
-      const CapabilityFilter& capability_filter,
+      const CapabilityFilter& filter,
       const base::Closure& on_application_end,
       const Shell::ConnectToApplicationCallback& connect_callback);
 
   void ConnectToApplication(scoped_ptr<ConnectToApplicationParams> params);
 
   // Must only be used by shell internals and test code as it does not forward
   // capability filters.
   template <typename Interface>
   inline void ConnectToService(const GURL& application_url,
                                InterfacePtr<Interface>* ptr) {
@@ skipping 147 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ApplicationManager);
 };
 
 Shell::ConnectToApplicationCallback EmptyConnectCallback();
 
 }  // namespace shell
 }  // namespace mojo
 
 #endif  // MOJO_SHELL_APPLICATION_MANAGER_H_