Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1318523006: PPC: [es6] Re-implement rest parameters via desugaring. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Re-implement rest parameters via desugaring. Port 510baeacbab311798d5e8795800ff773d00d062c Original commit message: Kills the kRestParameter bailout/disabled optimization, and fixes lazily parsed arrow functions with rest parameters. Supercedes https://crrev.com/1235153006/ R=caitpotter88@gmail.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:508074, v8:2160, v8:2700 LOG=N Committed: https://crrev.com/9628d86085ddee83067c45046ed89e0e6f635d3f Cr-Commit-Position: refs/heads/master@{#30574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-03 16:24:41 UTC) #1
caitp (gmail)
Non-owner LGTM
5 years, 3 months ago (2015-09-03 17:13:40 UTC) #2
dstence
lgtm
5 years, 3 months ago (2015-09-03 18:12:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318523006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318523006/1
5 years, 3 months ago (2015-09-03 18:16:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 18:40:15 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 18:40:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9628d86085ddee83067c45046ed89e0e6f635d3f
Cr-Commit-Position: refs/heads/master@{#30574}

Powered by Google App Engine
This is Rietveld 408576698