Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318513003: [Android] Add gyp support for multidex. (RELAND) (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
Yaron, Nico, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add gyp support for multidex. (RELAND) Reland of https://codereview.chromium.org/1278573002 BUG=272790 TBR=thakis@chromium.org,mmenke@chromium.org Committed: https://crrev.com/f091dcb5146ce071e183303bd316f06e92b6ee3e Cr-Commit-Position: refs/heads/master@{#345443}

Patch Set 1 #

Patch Set 2 : add @VisibleForTesting to ChromiumMultiDex.install #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -22 lines) Patch
M base/BUILD.gn View 2 chunks +19 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +11 lines, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/annotations/MainDex.java View 2 chunks +7 lines, -6 lines 0 comments Download
A base/android/java/src/org/chromium/base/multidex/ChromiumMultiDex.java View 1 1 chunk +58 lines, -0 lines 0 comments Download
M base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M base/base.gyp View 2 chunks +19 lines, -0 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 3 chunks +8 lines, -0 lines 0 comments Download
A base/test/android/junit/src/org/chromium/base/test/shadows/ShadowMultiDex.java View 1 chunk +21 lines, -0 lines 0 comments Download
M build/android/ant/apk-package.xml View 3 chunks +31 lines, -2 lines 0 comments Download
M build/android/apkbuilder_action.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/gyp/dex.py View 3 chunks +50 lines, -2 lines 0 comments Download
A build/android/gyp/main_dex_list.py View 1 chunk +84 lines, -0 lines 0 comments Download
A build/android/main_dex_action.gypi View 1 chunk +44 lines, -0 lines 0 comments Download
A build/android/main_dex_classes.flags View 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M build/java.gypi View 3 chunks +10 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 9 chunks +48 lines, -4 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 2 chunks +4 lines, -3 lines 0 comments Download
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
ps1 is the original, ps2 is the fixed version. The only change is the addition ...
5 years, 4 months ago (2015-08-25 19:39:58 UTC) #2
Yaron
lgtm :S
5 years, 4 months ago (2015-08-25 20:53:11 UTC) #3
jbudorick
TBR thakis, mmenke: base/base.gyp and net/ (respectively) unchanged from previous CL
5 years, 4 months ago (2015-08-25 20:54:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318513003/20001
5 years, 4 months ago (2015-08-25 20:55:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 21:37:05 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 21:38:11 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f091dcb5146ce071e183303bd316f06e92b6ee3e
Cr-Commit-Position: refs/heads/master@{#345443}

Powered by Google App Engine
This is Rietveld 408576698