Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Issue 1318503005: A batch of docs style fixes. (Closed)

Created:
5 years, 4 months ago by Bons
Modified:
5 years, 4 months ago
Reviewers:
nodir
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A batch of docs style fixes. R=nodir BUG=524256 Committed: https://crrev.com/222c4ee3d222aca05d3c866c0bfdfd3e8346fc82 Cr-Commit-Position: refs/heads/master@{#345353}

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -169 lines) Patch
M docs/chromium_browser_vs_google_chrome.md View 1 1 chunk +48 lines, -16 lines 0 comments Download
M docs/chromoting_android_hacking.md View 2 chunks +80 lines, -43 lines 0 comments Download
M docs/chromoting_build_instructions.md View 2 chunks +137 lines, -71 lines 0 comments Download
M docs/clang_static_analyzer.md View 1 2 chunks +35 lines, -18 lines 0 comments Download
M docs/cygwin_dll_remapping_failure.md View 1 2 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bons
5 years, 4 months ago (2015-08-25 14:12:36 UTC) #1
nodir
lgtm % nits https://codereview.chromium.org/1318503005/diff/1/docs/chromium_browser_vs_google_chrome.md File docs/chromium_browser_vs_google_chrome.md (right): https://codereview.chromium.org/1318503005/diff/1/docs/chromium_browser_vs_google_chrome.md#newcode30 docs/chromium_browser_vs_google_chrome.md:30: ## Chromium blank space after header ...
5 years, 4 months ago (2015-08-25 14:39:48 UTC) #2
nodir
btw, I didn't know about ```shell, it is better than raw 4-space indentation (it highlights ...
5 years, 4 months ago (2015-08-25 14:42:12 UTC) #3
Bons
https://codereview.chromium.org/1318503005/diff/1/docs/chromium_browser_vs_google_chrome.md File docs/chromium_browser_vs_google_chrome.md (right): https://codereview.chromium.org/1318503005/diff/1/docs/chromium_browser_vs_google_chrome.md#newcode30 docs/chromium_browser_vs_google_chrome.md:30: ## Chromium On 2015/08/25 14:39:48, nodir wrote: > blank ...
5 years, 4 months ago (2015-08-25 16:41:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318503005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318503005/20001
5 years, 4 months ago (2015-08-25 16:42:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 16:51:08 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 16:51:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/222c4ee3d222aca05d3c866c0bfdfd3e8346fc82
Cr-Commit-Position: refs/heads/master@{#345353}

Powered by Google App Engine
This is Rietveld 408576698