Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/dom/src/Timer.dart

Issue 13185006: Redirect pure isolate print to helper isolate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/src/Timer.dart
diff --git a/tools/dom/src/Timer.dart b/tools/dom/src/Timer.dart
index 43a208afe0a43f0a43360e1361ec6cc656f1d36b..27e7b90a273a996acbfe914c719e7224cac66185 100644
--- a/tools/dom/src/Timer.dart
+++ b/tools/dom/src/Timer.dart
@@ -29,10 +29,6 @@ get _timerFactoryClosure => (int milliSeconds, void callback(Timer timer), bool
return timer;
};
-const _NEW_TIMER = 'NEW_TIMER';
-const _CANCEL_TIMER = 'CANCEL_TIMER';
-const _TIMER_PING = 'TIMER_PING';
-
class _PureIsolateTimer implements Timer {
final ReceivePort _port = new ReceivePort();
SendPort _sendPort; // Effectively final.
@@ -60,27 +56,6 @@ class _PureIsolateTimer implements Timer {
void _cancel() {
_port.close();
}
-
- static final Future<SendPort> _HELPER_ISOLATE_PORT =
- spawnDomFunction(_helperIsolateMain);
-}
-
-final _TIMER_REGISTRY = new Map<SendPort, Timer>();
-
-_helperIsolateMain() {
- port.receive((msg, replyTo) {
- final cmd = msg[0];
- if (cmd == _NEW_TIMER) {
- final duration = new Duration(milliseconds: msg[1]);
- bool periodic = msg[2];
- final callback = () { replyTo.send(_TIMER_PING); };
- _TIMER_REGISTRY[replyTo] = periodic ?
- new Timer.periodic(duration, callback) :
- new Timer(duration, callback);
- } else if (cmd == _CANCEL_TIMER) {
- _TIMER_REGISTRY.remove(replyTo).cancel();
- }
- });
}
get _pureIsolateTimerFactoryClosure =>

Powered by Google App Engine
This is Rietveld 408576698