Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/test/chromedriver/capabilities_parser.h

Issue 13185004: [chromedriver] Implement proxy capability. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_TEST_CHROMEDRIVER_CAPABILITIES_PARSER_H_
6 #define CHROME_TEST_CHROMEDRIVER_CAPABILITIES_PARSER_H_
7
8 #include <string>
9
10 #include "base/callback_forward.h"
11 #include "base/files/file_path.h"
12 #include "base/values.h"
13
14 class Status;
15
16 struct Capabilities {
17 Capabilities();
18 ~Capabilities();
19
20 bool HasAndroidPackage() const;
21
22 Status Parse(
23 const base::DictionaryValue& chrome_options,
24 const base::Callback<bool(const base::FilePath&)>& file_checker);
25
26 std::string android_package;
27
28 base::FilePath chrome_exe;
29 std::string log_path;
30 base::ListValue args;
kkania 2013/04/03 19:09:35 how about a std::vector<string> instead or a Comma
chrisgao (Use stgao instead) 2013/04/06 01:11:25 changed to a CommandLine.
31 const base::DictionaryValue* prefs;
kkania 2013/04/03 19:09:35 i think the capabilities object should own these,
chrisgao (Use stgao instead) 2013/04/06 01:11:25 Done.
32 const base::DictionaryValue* local_state;
33 const base::ListValue* extensions;
kkania 2013/04/03 19:09:35 how about a std::vector<string>?
chrisgao (Use stgao instead) 2013/04/06 01:11:25 Done.
34 };
35
36 #endif // CHROME_TEST_CHROMEDRIVER_CAPABILITIES_PARSER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698