Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1318493005: [turbofan] relative_id of splinters and their children. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] relative_id of splinters and their children. A LiveRange is identified by 2 integers: the vreg() of its TopLevel, which is the virtual register (operand) ID; and a relative_id(), which has no meaning in the program, but is valuable in debugging or tracing scenarios. This change ensures that relative_id is unique even in cases of splinter ranges and their children. Committed: https://crrev.com/96c0e6f96b3a4998aa2047951ddf11001d3bea08 Cr-Commit-Position: refs/heads/master@{#30665}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M src/compiler/register-allocator.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/live-range-unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-09 17:41:48 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-09 18:51:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318493005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318493005/20001
5 years, 3 months ago (2015-09-09 19:32:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 19:34:01 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 19:34:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96c0e6f96b3a4998aa2047951ddf11001d3bea08
Cr-Commit-Position: refs/heads/master@{#30665}

Powered by Google App Engine
This is Rietveld 408576698