content/browser/renderer_host/text_input_client_message_filter.mm - Issue 1318483007: Implement "Look Up In Dictionary" context menu item asynchronously. (OS X)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/text_input_client_message_filter.mm

Issue 1318483007: Implement "Look Up In Dictionary" context menu item asynchronously. (OS X) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_mac.mm ('K') | « content/browser/renderer_host/text_input_client_message_filter.h ('k') | content/common/text_input_client_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_client_message_filter.mm

diff --git a/content/browser/renderer_host/text_input_client_message_filter.mm b/content/browser/renderer_host/text_input_client_message_filter.mm

index 090daaa522da775d882171ee5a52ffb623bbee36..187d7fe26e558c4be71d680721609243eb43b314 100644

--- a/content/browser/renderer_host/text_input_client_message_filter.mm

+++ b/content/browser/renderer_host/text_input_client_message_filter.mm

@@ -65,13 +65,16 @@ void TextInputClientMessageFilter::OnGotFirstRectForRange(

}

void TextInputClientMessageFilter::OnGotStringFromRange(

- const mac::AttributedStringCoder::EncodedString& encoded_string) {

+ const mac::AttributedStringCoder::EncodedString& encoded_string,

+ const gfx::Point& point) {

TextInputClientMac* service = TextInputClientMac::GetInstance();

NSAttributedString* string =

mac::AttributedStringCoder::Decode(&encoded_string);

if (![string length])

string = nil;

service->SetSubstringAndSignal(string);

+ service->GetStringFromRangeReply(

+ string, NSPointFromCGPoint(point.ToCGPoint()));

}

} // namespace content