Implement "Look Up In Dictionary" context menu item asynchronously. (OS X)

content/browser/renderer_host/text_input_client_message_filter.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/text_input_client_message_filter.h"
 
 #include "base/strings/string16.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/text_input_client_mac.h"
 #include "content/common/text_input_client_messages.h"
@@ skipping 47 matching lines @@
   service->SetCharacterIndexAndSignal(index);
 }
 
 void TextInputClientMessageFilter::OnGotFirstRectForRange(
     const gfx::Rect& rect) {
   TextInputClientMac* service = TextInputClientMac::GetInstance();
   service->SetFirstRectAndSignal(NSRectFromCGRect(rect.ToCGRect()));
 }
 
 void TextInputClientMessageFilter::OnGotStringFromRange(
-    const mac::AttributedStringCoder::EncodedString& encoded_string) {
+    const mac::AttributedStringCoder::EncodedString& encoded_string,
+    const gfx::Point& point) {
   TextInputClientMac* service = TextInputClientMac::GetInstance();
   NSAttributedString* string =
       mac::AttributedStringCoder::Decode(&encoded_string);
   if (![string length])
     string = nil;
   service->SetSubstringAndSignal(string);

[Alexei Svitkine (slow), 2015/09/21 15:47:56]

Can this call be merged into GetStringFromRangeReply(), since this is the only
caller?

[Shu Chen, 2015/09/22 05:46:08]

Done.

+  service->GetStringFromRangeReply(
+      string, NSPointFromCGPoint(point.ToCGPoint()));

[Alexei Svitkine (slow), 2015/09/21 15:47:56]

Does it make sense to not do this when string is empty or nil (since there's an
early return above)? OnGotStringAtPoint() doesn't have the same logic. It seems
to me that it would make sense for them to be consistent - but perhaps I don't
know the implications here. What are they?

[Shu Chen, 2015/09/22 05:46:08]

This call is necessary when string is empty or nil, because
RVHVCocoa::showLookUpDictionaryOverlayInternal() needs to do things differently
if |string| is empty.

I don't see an early return above. But I've removed the unnecessary code: "if
(![string length]) string = nil;" in case that caused confusion.

 }
 
 }  // namespace content