Implement "Look Up In Dictionary" context menu item asynchronously. (OS X)

content/browser/renderer_host/text_input_client_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_CLIENT_MAC_H_
 #define CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_CLIENT_MAC_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_block.h"
@@ skipping 63 matching lines @@
   // responsible for bouncing to the main thread if necessary.
   // The callback parameters provide the attributed word under the point and
   // the lower left baseline point of the text.
   void GetStringAtPoint(RenderWidgetHost* rwh,
                         gfx::Point point,
                         void (^replyHandler)(NSAttributedString*, NSPoint));
   // This is called on the IO thread when we get the renderer's reply for
   // GetStringAtPoint.
   void GetStringAtPointReply(NSAttributedString*, NSPoint);
 
+  // This async method is invoked from RenderWidgetHostViewMacDictionaryHelper's
+  // ShowDefinitionForSelection().
+  // The reply callback will be invoked from the IO thread, the caller is
+  // responsible for bouncing to the main thread if necessary.
+  // The callback parameters provide the attributed word under the point and
+  // the lower left baseline point of the text.
+  void GetStringFromRange(RenderWidgetHost* rwh,
+                          NSRange range,
+                          void (^replyHandler)(NSAttributedString*, NSPoint));

[Alexei Svitkine (slow), 2015/09/18 16:48:43]

replyHandler -> reply_handler

[Shu Chen, 2015/09/21 02:47:39]

Done.

+  // This is called on the IO thread when we get the renderer's reply for

[Alexei Svitkine (slow), 2015/09/18 16:48:43]

Add an empty line above this.

[Shu Chen, 2015/09/21 02:47:39]

Done.

+  // GetStringFromRange.
+  void GetStringFromRangeReply(NSAttributedString*, NSPoint);

[Alexei Svitkine (slow), 2015/09/18 16:48:43]

Name the params.

[Shu Chen, 2015/09/21 02:47:39]

Done.

+
  private:
   friend struct DefaultSingletonTraits<TextInputClientMac>;
   TextInputClientMac();
   ~TextInputClientMac();
 
   // The critical sections that the Condition guards are in Get*() methods.
   // These methods lock the internal condition for use before the asynchronous
   // message is sent to the renderer to lookup the required information. These
   // are only used on the UI thread.
   void BeforeRequest();
   // Called at the end of a critical section. This will release the lock and
   // condition.
   void AfterRequest();
 
   NSUInteger character_index_;
   NSRect first_rect_;
   base::scoped_nsobject<NSAttributedString> substring_;
 
   base::Lock lock_;
   base::ConditionVariable condition_;
 
-  base::mac::ScopedBlock<void(^)(NSAttributedString*, NSPoint)> replyHandler_;
+  base::mac::ScopedBlock<void(^)(NSAttributedString*, NSPoint)>

[Alexei Svitkine (slow), 2015/09/18 16:48:43]

Add comments.

[Shu Chen, 2015/09/21 02:47:39]

Done.

+      replyForPointHandler_;
+  base::mac::ScopedBlock<void(^)(NSAttributedString*, NSPoint)>
+      replyForRangeHandler_;
 
   DISALLOW_COPY_AND_ASSIGN(TextInputClientMac);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_CLIENT_MAC_H_