Updated UploadProgress tests under ThreadSanitizer

Updated UploadProgress tests under ThreadSanitizer
We now send a smaller payload when using ThreadSanitizer

BUG=526985
Committed: https://crrev.com/e33eeff0ec4e340c2d61eefd95527727e0ba3cdf
Cr-Commit-Position: refs/heads/master@{#346988}

[Charlie Harrison, 2015-09-01 18:09:47]

csharrison@chromium.org changed reviewers:
+ mmenke@chromium.org

[Charlie Harrison, 2015-09-01 18:09:47]

This seems to have fixed the issue. I just reduced the upload size for TS
builds.

[mmenke, 2015-09-01 18:37:42]

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
File content/browser/loader/async_resource_handler_browsertest.cc (right):

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:26: #if
defined(THREAD_SANITIZER)
Think this is worth a comment and a bug link

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:27: const size_t
kPayloadSize = 9565938; // 2*3^14
Cutting data size by just 1/3rd seems to be cutting things a bit close.  I'd
suggest going with 2*3^12, out of paranoia.

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:29: const
std::string kRedirectScript = "WaitForAsyncXHR('/redirect', 'small');";
I suggest passing in kPayloadSize instead.

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:72:
printf("Navigated To URL...\n");
nit:  Remove printf

[Charlie Harrison, 2015-09-01 20:29:57]

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
File content/browser/loader/async_resource_handler_browsertest.cc (right):

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:26: #if
defined(THREAD_SANITIZER)
On 2015/09/01 18:37:42, mmenke wrote:
> Think this is worth a comment and a bug link

Done.

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:27: const size_t
kPayloadSize = 9565938; // 2*3^14
On 2015/09/01 18:37:42, mmenke wrote:
> Cutting data size by just 1/3rd seems to be cutting things a bit close.  I'd
> suggest going with 2*3^12, out of paranoia.

Done.

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:29: const
std::string kRedirectScript = "WaitForAsyncXHR('/redirect', 'small');";
On 2015/09/01 18:37:42, mmenke wrote:
> I suggest passing in kPayloadSize instead.

How do you suggest I do that? Manually via a string or something like sprintf?

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:72:
printf("Navigated To URL...\n");
On 2015/09/01 18:37:42, mmenke wrote:
> nit:  Remove printf

Done. Oops.

[mmenke, 2015-09-01 20:31:39]

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
File content/browser/loader/async_resource_handler_browsertest.cc (right):

https://codereview.chromium.org/1318393003/diff/1/content/browser/loader/asyn...
content/browser/loader/async_resource_handler_browsertest.cc:29: const
std::string kRedirectScript = "WaitForAsyncXHR('/redirect', 'small');";
On 2015/09/01 20:29:57, csharrison wrote:
> On 2015/09/01 18:37:42, mmenke wrote:
> > I suggest passing in kPayloadSize instead.
> 
> How do you suggest I do that? Manually via a string or something like sprintf?

base::StringPrintf

[Charlie Harrison, 2015-09-01 21:01:35]

Thanks for the quick comments.

[mmenke, 2015-09-01 21:42:17]

LGTM!

[Charlie Harrison, 2015-09-01 21:44:17]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2015-09-01 21:45:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318393003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318393003/40001

[commit-bot: I haz the power, 2015-09-01 22:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 22:30:32]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Charlie Harrison, 2015-09-01 22:36:26]

On 2015/09/01 22:30:32, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

I thought %zu was the right formatting for size_t? What should it be on windows?

[Charlie Harrison, 2015-09-01 22:37:29]

On 2015/09/01 22:36:26, csharrison wrote:
> On 2015/09/01 22:30:32, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
> 
> I thought %zu was the right formatting for size_t? What should it be on
windows?

Or rather, what's portable?

[Charlie Harrison, 2015-09-02 17:42:32]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2015-09-02 17:42:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1318393003/#ps60001
(title: "portable size_t formatting")

[commit-bot: I haz the power, 2015-09-02 17:43:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318393003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318393003/60001

[commit-bot: I haz the power, 2015-09-02 19:09:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-02 19:10:18]

Patchset 4 (id:??) landed as
https://crrev.com/e33eeff0ec4e340c2d61eefd95527727e0ba3cdf
Cr-Commit-Position: refs/heads/master@{#346988}