third_party/WebKit/Source/modules/mediastream/MediaStreamConstraints.idl - Issue 1318393002: Refactor "track options" to be a dictionary.

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/MediaStreamConstraints.idl

Issue 1318393002: Refactor "track options" to be a dictionary. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Used MediaTrackConstraintSet in union types Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp ('K') | « third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp ('k') | third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl » ('j') | third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 // Use of this source code is governed by a BSD-style license that can be

3 *	3 // found in the LICENSE file.

4 * This library is free software; you can redistribute it and/or	4

5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.

8 *

9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

12 * Library General Public License for more details.

13 *

14 * You should have received a copy of the GNU Library General Public License

15 * along with this library; see the file COPYING.LIB. If not, write to

16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,

17 * Boston, MA 02110-1301, USA.

18 */

19	5
	Peter Beverloo 2015/10/05 13:49:09 micro nit: please link to the spec // https://w3c micro nit: please link to the spec // https://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream... hta - Chromium 2015/10/05 21:28:06 Done. Show quoted text On 2015/10/05 13:49:09, Peter Beverloo wrote: > micro nit: please link to the spec > > // > https://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream... Done.
20 dictionary MediaStreamConstraints {	6 dictionary MediaStreamConstraints {

21 (boolean or Dictionary) video = false;	7 // Dictionary should be MediaTrackConstraintSet. crbug/524424 blocks this.
	Peter Beverloo 2015/10/05 13:49:09 nit: crbug.com/524424 You may want to phrase this nit: crbug.com/524424 You may want to phrase this as a TODO to resolve when the issue is fixed. The information in lines 8-10 would be of more value in the bug. (As the canonical place for information on the issue.) hta - Chromium 2015/10/05 21:28:06 This is embarassing ... 524424 is fixed, and I for Show quoted text On 2015/10/05 13:49:09, Peter Beverloo wrote: > nit: crbug.com/524424 > > You may want to phrase this as a TODO to resolve when the issue is fixed. The > information in lines 8-10 would be of more value in the bug. (As the canonical > place for information on the issue.) This is embarassing ... 524424 is fixed, and I forgot to delete the comment!
22 (boolean or Dictionary) audio = false;	8 // This compiles with a patch to generated file

	9 // out/Debug/gen/blink/bindings/modules/v8/UnionTypesModules.h

	10 // to #include "modules/mediastream/MediaTrackConstraintSet.h".

	11 (boolean or MediaTrackConstraintSet) video;

	12 (boolean or MediaTrackConstraintSet) audio;

23 };	13 };

OLD	NEW