third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.h - Issue 1318393002: Refactor "track options" to be a dictionary.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.h

Issue 1318393002: Refactor "track options" to be a dictionary. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: More review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp » ('j') | third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 #ifndef MediaConstraintsImpl_h	31 #ifndef MediaConstraintsImpl_h

32 #define MediaConstraintsImpl_h	32 #define MediaConstraintsImpl_h

33	33

34 #include "public/platform/WebMediaConstraints.h"	34 #include "public/platform/WebMediaConstraints.h"

35	35

36 namespace blink {	36 namespace blink {

37	37

38 class Dictionary;	38 class Dictionary;

39 class ExceptionState;	39 class ExceptionState;

	40 class MediaTrackConstraintSet;

40	41

41 namespace MediaConstraintsImpl {	42 namespace MediaConstraintsImpl {

42	43

43 WebMediaConstraints create();	44 WebMediaConstraints create();

44 WebMediaConstraints create(const Dictionary&, ExceptionState&);	45 WebMediaConstraints create(const Dictionary&, ExceptionState&);

	46 WebMediaConstraints create(const MediaTrackConstraintSet&, ExceptionState&);

45	47

46 }	48 }

47	49

48 } // namespace blink	50 } // namespace blink

49	51

50 #endif // MediaConstraintsImpl_h	52 #endif // MediaConstraintsImpl_h

51	53

52	54

OLD	NEW