Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1318343003: Annotate GN executables and shared_libraries with sanitizer deps. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
dirk pranke. xhwang, Dirk Pranke, achuithb
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, dmazzoni+watch_chromium.org, piman+watch_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, pvalenzuela+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, samuong+watch_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, eme-reviews_chromium.org, je_julie, darin-cc_chromium.org, yfriedman+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, jbudorick+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, tapted, jasonroberts+watch_google.com, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, caitkp+watch_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, Michael Moss, klundberg+watch_chromium.org, jochen+watch_chromium.org, kalyank, plundblad+watch_chromium.org, nektar+watch_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, isheriff+watch_chromium.org, ozone-reviews_chromium.org, Aaron Boodman, plaree+watch_chromium.org, telemetry-reviews_chromium.org, dtseng+watch_chromium.org, tfarina, darin (slow to review), lcwu+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Annotate GN executables and shared_libraries with sanitizer deps. These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Committed: https://crrev.com/ba7a73dd61db639f42cc6283939f8b44cc4ecc6c Cr-Commit-Position: refs/heads/master@{#346490}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : merge #

Patch Set 5 : merge #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -18 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M base/android/linker/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M breakpad/BUILD.gn View 12 chunks +27 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/convert_dict/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/profile_reset/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/service_discovery_sniffer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/BUILD.gn View 1 2 3 6 chunks +17 lines, -4 lines 0 comments Download
M chromecast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/wifi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M courgette/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M dbus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/BUILD.gn View 2 chunks +5 lines, -3 lines 0 comments Download
M gpu/skia_runner/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/tools/compositor_model_bench/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 21 chunks +25 lines, -4 lines 0 comments Download
M ppapi/BUILD.gn View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/tools/javascript_key_tester/pnacl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M rlz/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M sandbox/win/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M skia/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/android_platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_protobuf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/cld_2/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/codesighs/BUILD.gn View 5 chunks +20 lines, -0 lines 0 comments Download
M third_party/freetype2/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/iaccessible2/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/opus/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/qcms/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/forwarder2/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/android/md5sum/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/imagediff/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/clear_system_cache/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ozone/demo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/egltest/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/examples/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M win8/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 32 (15 generated)
brettw
5 years, 3 months ago (2015-08-28 23:50:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318343003/10078 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318343003/10078
5 years, 3 months ago (2015-08-28 23:51:02 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/91295) ios_dbg_simulator_ninja on ...
5 years, 3 months ago (2015-08-28 23:53:51 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318343003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318343003/50001
5 years, 3 months ago (2015-08-29 04:04:19 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-29 05:33:42 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318343003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318343003/70001
5 years, 3 months ago (2015-08-31 17:14:24 UTC) #12
brettw
5 years, 3 months ago (2015-08-31 17:17:04 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-31 18:35:43 UTC) #16
achuithb
rubberstamp lgtm for tools/perf and tools/telemetry
5 years, 3 months ago (2015-08-31 18:54:39 UTC) #17
Dirk Pranke
reluctant, somewhat-rubber-stamp lgtm. It's unfortunate that we have to do this, but I'm not seeing ...
5 years, 3 months ago (2015-08-31 20:06:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318343003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318343003/70001
5 years, 3 months ago (2015-08-31 20:41:25 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/94852)
5 years, 3 months ago (2015-08-31 20:49:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318343003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318343003/90001
5 years, 3 months ago (2015-08-31 21:03:34 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/126796)
5 years, 3 months ago (2015-08-31 21:32:24 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318343003/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318343003/90001
5 years, 3 months ago (2015-08-31 21:35:31 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 3 months ago (2015-08-31 22:17:48 UTC) #31
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 22:18:32 UTC) #32
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ba7a73dd61db639f42cc6283939f8b44cc4ecc6c
Cr-Commit-Position: refs/heads/master@{#346490}

Powered by Google App Engine
This is Rietveld 408576698