Issue 131833004: Unrevert 244233 "Add support for using expressions as enum values."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131833004: Unrevert 244233 "Add support for using expressions as enum values." (Closed)

Created:
6 years, 11 months ago by Matt Perry

Modified:
6 years, 11 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Unrevert 244233 "Add support for using expressions as enum values." First time broke the build with a non-ASCII character in a comment. BUG=320090 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244250

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+393 lines, -116 lines)			Patch
A	mojo/public/bindings/parse/mojo_lexer.py	View	1 chunk	+304 lines, -0 lines	0 comments	Download
M	mojo/public/bindings/parse/mojo_parser.py	View	9 chunks	+86 lines, -114 lines	0 comments	Download
M	mojo/public/bindings/sample/sample_service.mojom	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Matt Perry

Committed patchset #1 manually as r244250 (presubmit successful).

6 years, 11 months ago (2014-01-10 21:45:31 UTC) #1

Message was sent while issue was closed.

LGTM