Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 131833003: Update Breakpad to r1270 (Closed)

Created:
6 years, 11 months ago by Mark Mentovai
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Update Breakpad to r1270. r1263: Run svn propdel svn:executable on source code files. r1264: Fix warnings from the Windows build. r1265: Switch scoped_ptr.h to a compatible google3 implementation. r1266: Use a proper ignore_result() to fix a warn_unused_result warning. r1267: Windows: Fix remaining level 4 warnings. r1268: Fix build with Mac OS X 10.9 SDK. r1269: Fix #include order from r1268. r1270: Don't do work inside assert(). Ever. BUG=331268 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
TBR (DEPS)
6 years, 11 months ago (2014-01-10 20:00:53 UTC) #1
Lei Zhang
lgtm
6 years, 11 months ago (2014-01-10 20:01:43 UTC) #2
Mark Mentovai
6 years, 11 months ago (2014-01-10 21:10:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r244238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698