 Chromium Code Reviews
 Chromium Code Reviews Issue 1318293002:
  Only expose Notification.requestPermission() on the Window global.  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk
    
  
    Issue 1318293002:
  Only expose Notification.requestPermission() on the Window global.  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW | 
|---|---|
| 1 {% include 'copyright_block.txt' %} | 1 {% include 'copyright_block.txt' %} | 
| 2 #include "config.h" | 2 #include "config.h" | 
| 3 {% filter conditional(conditional_string) %} | 3 {% filter conditional(conditional_string) %} | 
| 4 #include "{{v8_class_or_partial}}.h" | 4 #include "{{v8_class_or_partial}}.h" | 
| 5 | 5 | 
| 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} | 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} | 
| 7 #include "{{filename}}" | 7 #include "{{filename}}" | 
| 8 {% endfor %} | 8 {% endfor %} | 
| 9 | 9 | 
| 10 namespace blink { | 10 namespace blink { | 
| (...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 332 {% endfilter %} | 332 {% endfilter %} | 
| 333 | 333 | 
| 334 {% if constructors or has_custom_constructor or has_event_constructor %} | 334 {% if constructors or has_custom_constructor or has_event_constructor %} | 
| 335 functionTemplate->SetCallHandler({{v8_class}}::constructorCallback); | 335 functionTemplate->SetCallHandler({{v8_class}}::constructorCallback); | 
| 336 functionTemplate->SetLength({{interface_length}}); | 336 functionTemplate->SetLength({{interface_length}}); | 
| 337 {% endif %} | 337 {% endif %} | 
| 338 v8::Local<v8::ObjectTemplate> instanceTemplate = functionTemplate->InstanceT emplate(); | 338 v8::Local<v8::ObjectTemplate> instanceTemplate = functionTemplate->InstanceT emplate(); | 
| 339 ALLOW_UNUSED_LOCAL(instanceTemplate); | 339 ALLOW_UNUSED_LOCAL(instanceTemplate); | 
| 340 v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->Prototyp eTemplate(); | 340 v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->Prototyp eTemplate(); | 
| 341 ALLOW_UNUSED_LOCAL(prototypeTemplate); | 341 ALLOW_UNUSED_LOCAL(prototypeTemplate); | 
| 342 {% if custom_registration_methods %} | |
| 343 ExecutionContext* context = currentExecutionContext(isolate); | |
| 
Peter Beverloo
2015/08/28 15:58:58
This will only be needed for *one* use of |custom_
 
haraken
2015/08/29 08:04:57
Would you help me understand where the context is
 | |
| 344 ALLOW_UNUSED_LOCAL(context); | |
| 345 {% endif %} | |
| 342 {% if has_access_check_callbacks %} | 346 {% if has_access_check_callbacks %} | 
| 343 instanceTemplate->SetAccessCheckCallbacks({{cpp_class}}V8Internal::namedSecu rityCheck, {{cpp_class}}V8Internal::indexedSecurityCheck, v8::External::New(isol ate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo))); | 347 instanceTemplate->SetAccessCheckCallbacks({{cpp_class}}V8Internal::namedSecu rityCheck, {{cpp_class}}V8Internal::indexedSecurityCheck, v8::External::New(isol ate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo))); | 
| 344 {% endif %} | 348 {% endif %} | 
| 345 {% for attribute in attributes | 349 {% for attribute in attributes | 
| 346 if attribute.runtime_enabled_function and | 350 if attribute.runtime_enabled_function and | 
| 347 not attribute.exposed_test %} | 351 not attribute.exposed_test %} | 
| 348 {% filter conditional(attribute.conditional_string) %} | 352 {% filter conditional(attribute.conditional_string) %} | 
| 349 if ({{attribute.runtime_enabled_function}}()) { | 353 if ({{attribute.runtime_enabled_function}}()) { | 
| 350 {% if attribute.is_data_type_property %} | 354 {% if attribute.is_data_type_property %} | 
| 351 static const V8DOMConfiguration::AttributeConfiguration attributeConfigu ration = \ | 355 static const V8DOMConfiguration::AttributeConfiguration attributeConfigu ration = \ | 
| (...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 490 {% endfor %} | 494 {% endfor %} | 
| 491 {% for attribute in attributes if attribute.is_implemented_in_private_script %} | 495 {% for attribute in attributes if attribute.is_implemented_in_private_script %} | 
| 492 {{attribute_getter_implemented_in_private_script(attribute)}} | 496 {{attribute_getter_implemented_in_private_script(attribute)}} | 
| 493 {% if attribute.has_setter %} | 497 {% if attribute.has_setter %} | 
| 494 {{attribute_setter_implemented_in_private_script(attribute)}} | 498 {{attribute_setter_implemented_in_private_script(attribute)}} | 
| 495 {% endif %} | 499 {% endif %} | 
| 496 {% endfor %} | 500 {% endfor %} | 
| 497 {% block partial_interface %}{% endblock %} | 501 {% block partial_interface %}{% endblock %} | 
| 498 } // namespace blink | 502 } // namespace blink | 
| 499 {% endfilter %} | 503 {% endfilter %} | 
| OLD | NEW |