Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1318253002: Test that "yield" expressions are disallowed in arrow formal parameter initializers (Closed)

Created:
5 years, 3 months ago by wingo
Modified:
5 years, 3 months ago
Reviewers:
conradw, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test that "yield" expressions are disallowed in arrow formal parameter initializers R=adamk@chromium.org LOG=N BUG=v8:4397, v8:4394 Committed: https://crrev.com/5f2d6ef69a52997109f877261b13f46776893474 Cr-Commit-Position: refs/heads/master@{#30459}

Patch Set 1 #

Patch Set 2 : Add tests for arrow functions and yield in initializers #

Patch Set 3 : Fix typo #

Patch Set 4 : Remove tests for 'use strict' in function bodies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M test/cctest/test-parsing.cc View 1 2 3 2 chunks +48 lines, -17 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
wingo
The late catch in https://codereview.chromium.org/1320673007/ where I added a "if (*ok == false) return" fixed ...
5 years, 3 months ago (2015-08-28 10:04:39 UTC) #1
wingo
On 2015/08/28 10:04:39, wingo wrote: > The late catch in https://codereview.chromium.org/1320673007/ where I added a ...
5 years, 3 months ago (2015-08-28 10:31:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318253002/40001
5 years, 3 months ago (2015-08-28 10:39:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 11:03:45 UTC) #7
caitp (gmail)
The cl description refers to something which is no longer legal js (language mode directive ...
5 years, 3 months ago (2015-08-28 11:18:58 UTC) #8
wingo
On 2015/08/28 11:18:58, caitp wrote: > The cl description refers to something which is no ...
5 years, 3 months ago (2015-08-28 11:28:47 UTC) #9
wingo
Updated description to reflect recent spec change, removed invalid tests.
5 years, 3 months ago (2015-08-28 12:37:19 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318253002/60001
5 years, 3 months ago (2015-08-28 12:37:40 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 13:20:14 UTC) #14
adamk
lgtm, but CL description maybe should note that this is a test-only change
5 years, 3 months ago (2015-08-28 15:35:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318253002/60001
5 years, 3 months ago (2015-08-31 08:24:06 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-08-31 08:47:52 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 08:47:59 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5f2d6ef69a52997109f877261b13f46776893474
Cr-Commit-Position: refs/heads/master@{#30459}

Powered by Google App Engine
This is Rietveld 408576698