Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: Source/core/editing/VisibleSelection.cpp

Issue 1318183002: Move global function intersectsNode() to local function in FrameSelection.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T10:16:38 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleSelection.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleSelection.cpp
diff --git a/Source/core/editing/VisibleSelection.cpp b/Source/core/editing/VisibleSelection.cpp
index e09f638170f9be4a287a4c28e8df4704118209cc..e10c51a1e397a7ff1c879442ccfb94ce9d6db2a4 100644
--- a/Source/core/editing/VisibleSelection.cpp
+++ b/Source/core/editing/VisibleSelection.cpp
@@ -230,18 +230,6 @@ PassRefPtrWillBeRawPtr<Range> firstRangeOf(const VisibleSelection& selection)
return Range::create(*start.document(), start, end);
}
-// TODO(yosin) We should move |intersectsNode()| to "FrameSelection.cpp".
-bool intersectsNode(const VisibleSelection& selection, Node* node)
-{
- if (selection.isNone())
- return false;
- Position start = selection.start().parentAnchoredEquivalent();
- Position end = selection.end().parentAnchoredEquivalent();
- TrackExceptionState exceptionState;
- // TODO(yosin) We should avoid to use |Range::intersectsNode()|.
- return Range::intersectsNode(node, start, end, exceptionState) && !exceptionState.hadException();
-}
-
template <typename Strategy>
static EphemeralRangeTemplate<Strategy> normalizeRangeAlgorithm(const EphemeralRangeTemplate<Strategy>& range)
{
« no previous file with comments | « Source/core/editing/VisibleSelection.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698