Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1318153006: MIPS64: [turbofan] Improve changes from and to Smi. (Closed)

Created:
5 years, 3 months ago by dusan.milosavljevic
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [turbofan] Improve changes from and to Smi. The instruction selection for following sequences is improved: 113: Word64Sar(107, 91) : Internal/Any 114: TruncateInt64ToInt32(113) : Signed32/UntaggedSigned32 115: ChangeInt32ToFloat64(114) : Signed32/UntaggedFloat64 TEST=unittests/InstructionSelectorTest.ChangesFromToSmi BUG= Committed: https://crrev.com/4329a7c2cf2f5641284251afe388edd65b17a4d7 Cr-Commit-Position: refs/heads/master@{#30645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dusan.milosavljevic
PTAL.
5 years, 3 months ago (2015-09-08 16:47:45 UTC) #2
paul.l...
LGTM, thanks!
5 years, 3 months ago (2015-09-08 18:22:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318153006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318153006/1
5 years, 3 months ago (2015-09-08 21:28:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 21:54:59 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 21:55:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4329a7c2cf2f5641284251afe388edd65b17a4d7
Cr-Commit-Position: refs/heads/master@{#30645}

Powered by Google App Engine
This is Rietveld 408576698