Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/BUILD.gn

Issue 1318153005: Bump min SDK version to 10.9 and suppress deprecation warnings (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | build/config/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index fea9027e4b3962a49035fac1da33170773630203..101297006ae8d22461af3c823f3f56766505af9f 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -770,6 +770,9 @@ component("base") {
"strings/sys_string_conversions_posix.cc",
"threading/platform_thread_internal_posix.cc",
]
+
+ # 10.6 vs 10.9 min sdk version
cdotstout 2015/09/08 21:10:20 Can you clarify this comment?
+ cflags = [ "-Wno-deprecated-declarations" ]
} else {
# Non-Mac.
sources -= [
« no previous file with comments | « BUILD.gn ('k') | build/config/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698