Chromium Code Reviews

Issue 1318153005: Bump min SDK version to 10.9 and suppress deprecation warnings (Closed)

Created:
5 years, 3 months ago by jamesr
Modified:
5 years, 3 months ago
Reviewers:
cdotstout, tonyg
CC:
mojo-reviews_chromium.org, tonyg
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Bump min SDK version to 10.9 and suppress deprecation warnings This implies using a modern C++ library (libc++) which can use C++11 features we rely on for cross compiling to Android. This suppresses deprecation warnings in base and skia as those libraries need to work in environments that target a min sdk version of 10.6. R=cstout@chromium.org, tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c4ebd590b6e2749a4ab3f97fd49bbd3a4d510759

Patch Set 1 #

Total comments: 1

Patch Set 2 : clarify comment #

Unified diffs Side-by-side diffs Stats (+14 lines, -8 lines)
M BUILD.gn View 1 chunk +5 lines, -6 lines 0 comments
M base/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments
M build/config/mac/BUILD.gn View 1 chunk +1 line, -1 line 0 comments
M skia/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments

Messages

Total messages: 9 (2 generated)
jamesr
5 years, 3 months ago (2015-08-31 21:37:08 UTC) #2
tonyg
Not sure what's up w/ the trybots, but this lgtm
5 years, 3 months ago (2015-09-03 17:34:04 UTC) #4
jamesr
I think the tree was busted when these patches hit the trybots. I'll resend.
5 years, 3 months ago (2015-09-03 17:35:39 UTC) #5
cdotstout
https://codereview.chromium.org/1318153005/diff/1/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/1318153005/diff/1/base/BUILD.gn#newcode774 base/BUILD.gn:774: # 10.6 vs 10.9 min sdk version Can you ...
5 years, 3 months ago (2015-09-08 21:10:20 UTC) #6
jamesr
Good point, done.
5 years, 3 months ago (2015-09-08 21:16:51 UTC) #7
cdotstout
lgtm
5 years, 3 months ago (2015-09-09 16:32:16 UTC) #8
jamesr
5 years, 3 months ago (2015-09-09 17:57:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c4ebd590b6e2749a4ab3f97fd49bbd3a4d510759 (presubmit successful).

Powered by Google App Engine