Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: docs/how_to_extend_layout_test_framework.md

Issue 1318153003: [Docs] fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | docs/linux_build_instructions.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/how_to_extend_layout_test_framework.md
diff --git a/docs/how_to_extend_layout_test_framework.md b/docs/how_to_extend_layout_test_framework.md
index de61e689ebc76a5e2e5262bdccb3ae79b1c9efce..32d3b33f1aa043b27926ce0b6cb6d42242de64d0 100644
--- a/docs/how_to_extend_layout_test_framework.md
+++ b/docs/how_to_extend_layout_test_framework.md
@@ -31,17 +31,12 @@ what exactly exactly is being tested.
This part isn’t too difficult. There are basically two classes that need to be
extended (ideally, just inherited from). These classes are:
- Driver
-
-Located in `layout_tests/port/driver.py`. Each instance of this is the class
-that will actually an instance of the program that produces the test data
-(program in Part 2).
-
- Port
-
-Located in `layout_tests/port/base.py`. This class is responsible creating
-drivers with the correct settings, giving access to certain OS functionality to
-access expected files, etc.
+* `Driver`. Located in `layout_tests/port/driver.py`. Each instance of this is
+ the class that will actually an instance of the program that produces the
+ test data (program in Part 2).
+* `Port`. Located in `layout_tests/port/base.py`. This class is responsible
+ creating drivers with the correct settings, giving access to certain OS
+ functionality to access expected files, etc.
#### Extending Driver
@@ -119,6 +114,7 @@ tests in that directory, but it will find the correct TestExpectations file, the
platform specific expected files, etc.
Here are some of the functions that most likely need to be overridden.
+
* `driver_class`
* This should be overridden to allow the testing program to actually run.
By default the code will run content_shell, which might or might not be
« no previous file with comments | « no previous file | docs/linux_build_instructions.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698