skia: Initialize value passed to GetShaderiv in GLBench

skia: Initialize value passed to GetShaderiv in GLBench

The command buffer's GetShaderiv and GetProgramiv code checks
that the success value passed in is either -1 or 0.

Committed: https://skia.googlesource.com/skia/+/894a2e436289077cd09cc89e857bfa0a2e590ee8

[hendrikw, 2015-09-01 17:38:37]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-09-01 17:38:44]

PTAL, thanks!

[bsalomon, 2015-09-08 13:27:16]

https://codereview.chromium.org/1318143004/diff/20001/bench/GLBench.cpp
File bench/GLBench.cpp (right):

https://codereview.chromium.org/1318143004/diff/20001/bench/GLBench.cpp#newco...
bench/GLBench.cpp:73: GrGLint success = 0;
There is a macro GR_GL_ZERO_INIT. It is just defined to be zero but is meant to
document the zero inits for the command buffer. Can we use that? Otherwise lgtm.

[hendrikw, 2015-09-08 22:13:39]

On 2015/09/08 13:27:16, bsalomon wrote:
> https://codereview.chromium.org/1318143004/diff/20001/bench/GLBench.cpp
> File bench/GLBench.cpp (right):
> 
>
https://codereview.chromium.org/1318143004/diff/20001/bench/GLBench.cpp#newco...
> bench/GLBench.cpp:73: GrGLint success = 0;
> There is a macro GR_GL_ZERO_INIT. It is just defined to be zero but is meant
to
> document the zero inits for the command buffer. Can we use that? Otherwise
lgtm.

done!  thanks

[hendrikw, 2015-09-08 22:13:54]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-09-08 22:13:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1318143004/#ps60001
(title: "remove code that leaked in")

[commit-bot: I haz the power, 2015-09-08 22:14:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318143004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318143004/60001

[commit-bot: I haz the power, 2015-09-08 22:18:58]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/894a2e436289077cd09cc89e857bfa0a2e590ee8