build/config/BUILD.gn - Issue 1318143002: Always use ENABLE_PLUGINS to indicate plugins support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1318143002: Always use ENABLE_PLUGINS to indicate plugins support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tryjob failures: forgot to set/check ENABLE_PDF in a couple places. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 278baec69a0544f76b20f6844dade8d78a80de0e..488768d84f71fba10b8f55f9531f0827e5ba9c00 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -68,6 +68,9 @@ config("feature_flags") {

if (enable_plugins) {

defines += [ "ENABLE_PLUGINS=1" ]

}

+ if (enable_pdf) {

+ defines += [ "ENABLE_PDF=1" ]

+ }

if (enable_basic_printing || enable_print_preview) {

# Convenience define for ENABLE_BASIC_PRINTING || ENABLE_PRINT_PREVIEW.

defines += [ "ENABLE_PRINTING=1" ]

« no previous file with comments | « build/common.gypi ('k') | build/config/features.gni » ('j') | no next file with comments »