Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: build/config/features.gni

Issue 1318143002: Always use ENABLE_PLUGINS to indicate plugins support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tryjob failures: forgot to set/check ENABLE_PDF in a couple places. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains Chrome-feature-related build flags (see ui.gni for 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # UI-related ones). These should theoretically be moved to the build files of 6 # UI-related ones). These should theoretically be moved to the build files of
7 # the features themselves. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
11 # anything that needs a grit define must be in either this file or ui.gni. 11 # anything that needs a grit define must be in either this file or ui.gni.
12 # 12 #
13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't 13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how 14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how
15 # to set up feature flags. 15 # to set up feature flags.
16 16
17 import("//build/config/chrome_build.gni") 17 import("//build/config/chrome_build.gni")
18 if (is_android) { 18 if (is_android) {
19 import("//build/config/android/config.gni") 19 import("//build/config/android/config.gni")
20 } 20 }
21 21
22 declare_args() { 22 declare_args() {
23 # Multicast DNS. 23 # Multicast DNS.
24 enable_mdns = is_win || is_linux 24 enable_mdns = is_win || is_linux
25 25
26 enable_plugins = !is_android && !is_ios 26 enable_plugins = !is_android && !is_ios
27 enable_pdf = !is_android && !is_ios
27 28
28 # Enables Native Client support. 29 # Enables Native Client support.
29 # TODO(GYP): Get NaCl linking on other platforms. 30 # TODO(GYP): Get NaCl linking on other platforms.
30 # Also, see if we can always get rid of enable_nacl_untrusted and 31 # Also, see if we can always get rid of enable_nacl_untrusted and
31 # enable_pnacl and always build them if enable_nacl is true. 32 # enable_pnacl and always build them if enable_nacl is true.
32 # The "is_nacl" part of the condition is needed to ensure that 33 # The "is_nacl" part of the condition is needed to ensure that
33 # the untrusted code is built properly; arguably it should be 34 # the untrusted code is built properly; arguably it should be
34 # guarded by "is_nacl" directly rather than enable_nacl_untrusted, but 35 # guarded by "is_nacl" directly rather than enable_nacl_untrusted, but
35 # this will go away when Mac and Win are working and we can just use 36 # this will go away when Mac and Win are working and we can just use
36 # the commented out logic. 37 # the commented out logic.
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 # system). 204 # system).
204 # TODO(GYP) also require !embedded to enable. 205 # TODO(GYP) also require !embedded to enable.
205 use_gconf = is_linux && !is_chromeos 206 use_gconf = is_linux && !is_chromeos
206 207
207 # Whether to back up data before sync. 208 # Whether to back up data before sync.
208 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos) 209 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos)
209 210
210 # Enable WebVR support by default on Android 211 # Enable WebVR support by default on Android
211 # Still requires command line flag to access API 212 # Still requires command line flag to access API
212 enable_webvr = is_android 213 enable_webvr = is_android
OLDNEW
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698