Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318103003: mandoline: Obey --no-sandbox. (Closed)

Created:
5 years, 3 months ago by Elliot Glaysher
Modified:
5 years, 3 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Obey --no-sandbox. Other chrome binaries have a "--no-sandbox" for debugging. Add one to mandoline, too. BUG=492524 Committed: https://crrev.com/f92f6a6d916e9e83b0a4102505fc1051f1956685 Cr-Commit-Position: refs/heads/master@{#346031}

Patch Set 1 #

Patch Set 2 : Fix collision with content. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M mojo/shell/application_manager.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M mojo/shell/switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
sky: review fsamuel: fyi
5 years, 3 months ago (2015-08-27 21:47:40 UTC) #2
sky
LGTM
5 years, 3 months ago (2015-08-27 23:21:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318103003/20001
5 years, 3 months ago (2015-08-27 23:24:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 00:09:42 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 00:10:21 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f92f6a6d916e9e83b0a4102505fc1051f1956685
Cr-Commit-Position: refs/heads/master@{#346031}

Powered by Google App Engine
This is Rietveld 408576698