components/content_settings/core/browser/host_content_settings_map.h - Issue 1318083005: Remove HostContentSettingsMap::ContentTypeHasCompoundValue function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/host_content_settings_map.h

Issue 1318083005: Remove HostContentSettingsMap::ContentTypeHasCompoundValue function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-num-types-enum-3

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profile_resetter/profile_resetter_unittest.cc ('K') | « components/content_settings/core/browser/content_settings_utils.h ('k') | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/host_content_settings_map.h

diff --git a/components/content_settings/core/browser/host_content_settings_map.h b/components/content_settings/core/browser/host_content_settings_map.h

index 04a204d7af9b74cf58f69f5a3fec6a357cb5ae26..5b32e8cdc422820f2a4250a5642d1a1297337d8f 100644

--- a/components/content_settings/core/browser/host_content_settings_map.h

+++ b/components/content_settings/core/browser/host_content_settings_map.h

@@ -176,9 +176,9 @@ class HostContentSettingsMap : public content_settings::Observer,

// This should only be called on the UI thread.

void ClearSettingsForOneType(ContentSettingsType content_type);

- static bool IsValueAllowedForType(PrefService* prefs,

- const base::Value* value,

+ static bool IsValueAllowedForType(const base::Value* value,

ContentSettingsType content_type);

+ // TODO(raymes): Remove |prefs| from the below functions, it's unused.

static bool IsSettingAllowedForType(PrefService* prefs,

ContentSetting setting,

ContentSettingsType content_type);

@@ -186,9 +186,6 @@ class HostContentSettingsMap : public content_settings::Observer,

ContentSetting setting,

ContentSettingsType content_type);

- // Returns true if the values for content type are of type dictionary/map.

- static bool ContentTypeHasCompoundValue(ContentSettingsType type);

// RefcountedKeyedService implementation.

void ShutdownOnUIThread() override;