Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1318063006: mandoline: lock down the linux sandbox more. (Closed)

Created:
5 years, 3 months ago by Elliot Glaysher
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: lock down the linux sandbox more. Previously, the mandoline sandbox allowed all system calls except for access()/open()/faccessat()/openat(). This patch now uses the baseline sandboxing policy (which will error on many common syscalls and will crash on unwhitelisted calls). Added a few syscalls that we need for the compositor to the explicit allow list. BUG=492524 Committed: https://crrev.com/6b21046b63481355378258b8a37d029a6a742ca1 Cr-Commit-Position: refs/heads/master@{#346469}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Restrict getaffinity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M mojo/runner/linux_sandbox.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Elliot Glaysher
Should ftruncate be proxied? Should I try to lock down the other three calls to ...
5 years, 3 months ago (2015-08-31 19:28:27 UTC) #2
rickyz (no longer on Chrome)
lgtm If you haven't been looking at https://code.google.com/p/chromium/codesearch#chromium/src/content/common/sandbox_linux/bpf_gpu_policy_linux.cc already, that has our current GPU sandbox ...
5 years, 3 months ago (2015-08-31 20:42:43 UTC) #3
Elliot Glaysher
ben: owners stamp
5 years, 3 months ago (2015-08-31 20:48:16 UTC) #5
Ben Goodger (Google)
lgtm
5 years, 3 months ago (2015-08-31 20:53:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318063006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318063006/20001
5 years, 3 months ago (2015-08-31 20:57:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-31 21:11:23 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 21:12:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b21046b63481355378258b8a37d029a6a742ca1
Cr-Commit-Position: refs/heads/master@{#346469}

Powered by Google App Engine
This is Rietveld 408576698