pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart - Issue 1318043005: Support user generated custom native JS classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: about to land Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

index 4fc5ab6dd7ac8d1f0325182c82a61d3fa1575b79..8b20e2de9d3e8117878785ec9eceeb5a282d0d4a 100644

--- a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

@@ -68,7 +68,7 @@ class RuntimeTypeGenerator {

/// native classes.

/// TODO(herhut): Generate tests for native classes dynamically, as well.

void generateIsTest(Element other) {

- if (classElement.isNative ||

+ if (classElement.isJsInterop || classElement.isNative ||

!classElement.isSubclassOf(other)) {

result.properties[namer.operatorIs(other)] = js('1');

}