pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart - Issue 1318043005: Support user generated custom native JS classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: about to land Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

index e345a7c3b08426259622eca124ecb7ea1e061602..8ddbb43069d68ebd7927f69c5604fbe4ac91bdc7 100644

--- a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

@@ -71,6 +71,9 @@ class CustomElementsAnalysis {

if (!Elements.isNativeOrExtendsNative(classElement)) return;

if (classElement.isMixinApplication) return;

if (classElement.isAbstract) return;

+ // JsInterop classes are opaque interfaces without a concrete

+ // implementation.

+ if (classElement.isJsInterop) return;

joinFor(enqueuer).instantiatedClasses.add(classElement);

}