Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/js_backend/patch_resolver.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ptal Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/js_backend/js_interop_analysis.dart ('K') | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart » ('j') | pkg/compiler/lib/src/patch_parser.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/patch_resolver.dart
diff --git a/pkg/compiler/lib/src/js_backend/patch_resolver.dart b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
index 0949c8fbace9cdd0e692259e0b5741dc004eeccc..b0c9dddbcc71050da66d8850cc1e567192f215bf 100644
--- a/pkg/compiler/lib/src/js_backend/patch_resolver.dart
+++ b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
@@ -36,7 +36,7 @@ class PatchResolverTask extends CompilerTask {
});
checkMatchingPatchSignatures(element, patch);
element = patch;
- } else {
+ } else if (!element.isJsInterop){
Siggi Cherem (dart-lang) 2015/10/13 02:08:53 nit: add space after )
Jacob 2015/10/13 03:10:43 Done.
compiler.reportErrorMessage(
element, MessageKind.PATCH_EXTERNAL_WITHOUT_IMPLEMENTATION);
}
« pkg/compiler/lib/src/js_backend/js_interop_analysis.dart ('K') | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart » ('j') | pkg/compiler/lib/src/patch_parser.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698