Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: pkg/compiler/lib/src/js_backend/patch_resolver.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ptal Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/patch_resolver.dart
diff --git a/pkg/compiler/lib/src/js_backend/patch_resolver.dart b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
index 0949c8fbace9cdd0e692259e0b5741dc004eeccc..56e2f2472d02958397701ca3b90d296f695092a3 100644
--- a/pkg/compiler/lib/src/js_backend/patch_resolver.dart
+++ b/pkg/compiler/lib/src/js_backend/patch_resolver.dart
@@ -36,9 +36,6 @@ class PatchResolverTask extends CompilerTask {
});
checkMatchingPatchSignatures(element, patch);
element = patch;
- } else {
- compiler.reportErrorMessage(
- element, MessageKind.PATCH_EXTERNAL_WITHOUT_IMPLEMENTATION);
Siggi Cherem (dart-lang) 2015/10/06 22:38:02 rather than completely removing this, maybe we sho
Jacob 2015/10/13 01:19:23 discussed offline. added comment explaining why we
}
return element;
}

Powered by Google App Engine
This is Rietveld 408576698