Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: ptal Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
diff --git a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
index c1d51cc2f797f663aa49234eebffef938b083be1..cfbb8b32c7582345687dec504cd4c91349ba5cac 100644
--- a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
+++ b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
@@ -404,7 +404,7 @@ class MemberTypeInformation extends ElementTypeInformation
giveUp(inferrer);
return safeType(inferrer);
}
- if (inferrer.isNativeElement(element)) {
+ if (inferrer.isNativeElement(element) && !element.isConstructor) {
Siggi Cherem (dart-lang) 2015/10/06 22:38:01 is this change still needed? If so, maybe we need
Jacob 2015/10/13 01:19:23 removed the .isConstructor check here and added ||
// Use the type annotation as the type for native elements. We
// also give up on inferring to make sure this element never
// goes in the work queue.

Powered by Google App Engine
This is Rietveld 408576698