pkg/compiler/lib/src/js_backend/namer.dart - Issue 1318043005: Support user generated custom native JS classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: ptal Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/namer.dart

diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart

index 6156b277c2107c48dd750947b0bb977e9ad7b05a..5b84c0e8e0c3fd99793513151005e5b59b9c080a 100644

--- a/pkg/compiler/lib/src/js_backend/namer.dart

+++ b/pkg/compiler/lib/src/js_backend/namer.dart

@@ -764,6 +764,7 @@ class Namer {

if (element.hasFixedBackendName) {

// Certain native fields must be given a specific name. Native names must

// not contain '$'. We rely on this to avoid clashes.

+ // TODO(jacobr): we need to relax this constraint.

assert(enclosingClass.isNative &&

!element.fixedBackendName.contains(r'$'));