pkg/compiler/lib/src/inferrer/type_graph_nodes.dart - Issue 1318043005: Support user generated custom native JS classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

Issue 1318043005: Support user generated custom native JS classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: ptal Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

diff --git a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

index 900bd4796113c2e5f59a81b87b6b6ee86f0134fe..1d10bbe557843de4054f2fdb7dde38bf4342f774 100644

--- a/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

+++ b/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

@@ -400,7 +400,7 @@ class MemberTypeInformation extends ElementTypeInformation

giveUp(inferrer);

return safeType(inferrer);

}

- if (inferrer.isNativeElement(element)) {

+ if (inferrer.isNativeElement(element) && !element.isConstructor) {

// Use the type annotation as the type for native elements. We

// also give up on inferring to make sure this element never

// goes in the work queue.