Support user generated custom native JS classes.

pkg/compiler/lib/src/patch_parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This library contains the infrastructure to parse and integrate patch files.
  *
  * Three types of elements can be patched: [LibraryElement], [ClassElement],
  * [FunctionElement]. Patches are introduced in patch libraries which are loaded
  * together with the corresponding origin library. Which libraries that are
@@ skipping 115 matching lines @@
 import 'diagnostics/messages.dart' show
     MessageKind;
 import 'elements/elements.dart';
 import 'elements/modelx.dart' show
     BaseFunctionElementX,
     ClassElementX,
     GetterElementX,
     LibraryElementX,
     MetadataAnnotationX,
     SetterElementX;
+import 'js_backend/js_backend.dart' show
+    JavaScriptBackend;
 import 'library_loader.dart' show
     LibraryLoader;
 import 'parser/listener.dart' show
     Listener,
     ParserError;
 import 'parser/element_listener.dart' show
     ElementListener;
 import 'parser/member_listener.dart' show
     MemberListener;
 import 'parser/partial_elements.dart' show
@@ skipping 150 matching lines @@
 }
 
 void patchElement(Compiler compiler,
                   Element origin,
                   Element patch) {
   if (origin == null) {
     compiler.reportErrorMessage(
         patch, MessageKind.PATCH_NON_EXISTING, {'name': patch.name});
     return;
   }
+
   if (!(origin.isClass ||
         origin.isConstructor ||
         origin.isFunction ||
         origin.isAbstractField)) {
     // TODO(ahe): Remove this error when the parser rejects all bad modifiers.
     compiler.reportErrorMessage(origin, MessageKind.PATCH_NONPATCHABLE);
     return;
   }
   if (patch.isClass) {
     tryPatchClass(compiler, origin, patch);
@@ skipping 42 matching lines @@
   checkNativeAnnotation(compiler, patch);
 }
 
 /// Check whether [cls] has a `@Native(...)` annotation, and if so, set its
 /// native name from the annotation.
 checkNativeAnnotation(Compiler compiler, ClassElement cls) {
   EagerAnnotationHandler.checkAnnotation(compiler, cls,
       const NativeAnnotationHandler());
 }
 
+checkJsInteropAnnotation(Compiler compiler, element) {
+  EagerAnnotationHandler.checkAnnotation(compiler, element,
+      const JsInteropAnnotationHandler());
+}
+
+
 /// Abstract interface for pre-resolution detection of metadata.
 ///
 /// The detection is handled in two steps:
 /// - match the annotation syntactically and assume that the annotation is valid
 ///   if it looks correct,
 /// - setup a deferred action to check that the annotation has a valid constant
 ///   value and report an internal error if not.
 abstract class EagerAnnotationHandler<T> {
   /// Checks that [annotation] looks like a matching annotation and optionally
   /// applies actions on [element]. Returns a non-null annotation marker if the
@@ skipping 12 matching lines @@
   /// Checks [element] for metadata matching the [handler]. Return a non-null
   /// annotation marker matching metadata was found.
   static checkAnnotation(Compiler compiler,
                          Element element,
                          EagerAnnotationHandler handler) {
     for (MetadataAnnotation annotation in element.implementation.metadata) {
       var result = handler.apply(compiler, element, annotation);
       if (result != null) {
         // TODO(johnniwinther): Perform this check in
         // [Compiler.onLibrariesLoaded].
-        compiler.enqueuer.resolution.addDeferredAction(element, () {
+        // TODO(jacobr): annotation resolution needs to be refactored.
+        actionCallback() {
           annotation.ensureResolved(compiler.resolution);
           handler.validate(
               compiler, element, annotation,
               compiler.constants.getConstantValue(annotation.constant));
-        });
+        }
+        if (compiler.enqueuer.resolution.queueIsClosed) {
+          actionCallback();

[Siggi Cherem (dart-lang), 2015/10/06 22:38:02]

I was hoping that now that you moved the logic to `onCodegenStartup`, we should
be able to revert this change

[Jacob, 2015/10/13 01:19:24]

me too.. reverted.

+        } else {
+          compiler.enqueuer.resolution.addDeferredAction(element,
+              actionCallback);
+        }
         return result;
       }
     }
     return null;
   }
 }
 
 /// Annotation handler for pre-resolution detection of `@Native(...)`
 /// annotations.
 class NativeAnnotationHandler implements EagerAnnotationHandler<String> {
@@ skipping 29 matching lines @@
                 Element element,
                 MetadataAnnotation annotation,
                 ConstantValue constant) {
     if (constant.getType(compiler.coreTypes).element !=
             compiler.nativeAnnotationClass) {
       compiler.internalError(annotation, 'Invalid @Native(...) annotation.');
     }
   }
 }
 
+/// Annotation handler for pre-resolution detection of `@Js(...)`
+/// annotations.
+class JsInteropAnnotationHandler implements EagerAnnotationHandler<bool> {
+  const JsInteropAnnotationHandler();
+
+  bool hasJsNameAnnotation(MetadataAnnotation annotation) =>
+      annotation.beginToken != null && annotation.beginToken.next.value == 'Js';
+
+  bool apply(Compiler compiler,
+             Element element,
+             MetadataAnnotation annotation) {
+    bool hasJsInterop = hasJsNameAnnotation(annotation);
+    if (hasJsInterop) {
+      element.setHasJsInterop();
+    }
+    return hasJsInterop == true ? true : null;

[Siggi Cherem (dart-lang), 2015/10/06 22:38:02]

might be worth a tiny comment on why not return false (probably something to do
with the semantics of apply in the baseclass?)

[Jacob, 2015/10/13 01:19:24]

Done.

+  }
+
+  @override
+  void validate(Compiler compiler,
+                Element element,
+                MetadataAnnotation annotation,
+                ConstantValue constant) {
+    JavaScriptBackend backend = compiler.backend;
+    if (constant.getType(compiler.coreTypes).element !=
+        backend.jsAnnotationClass) {
+      compiler.internalError(annotation, 'Invalid @Js(...) annotation.');
+    }
+  }
+}
+
 /// Annotation handler for pre-resolution detection of `@patch` annotations.
 class PatchAnnotationHandler implements EagerAnnotationHandler<PatchVersion> {
   const PatchAnnotationHandler();
 
   PatchVersion getPatchVersion(MetadataAnnotation annotation) {
     if (annotation.beginToken != null) {
       if (annotation.beginToken.next.value == 'patch') {
         return const PatchVersion(null);
       } else if (annotation.beginToken.next.value == 'patch_full') {
         return const PatchVersion('full');
@@ skipping 166 matching lines @@
 
 class PatchVersion {
   final String tag;
 
   const PatchVersion(this.tag);
 
   bool isActive(String patchTag) => tag == null || tag == patchTag;
 
   String toString() => 'PatchVersion($tag)';
 }