DevTools: attempt to unflake http/tests/inspector/service-workers/service-workers-view.html.

Source/devtools/front_end/sdk/ServiceWorkerManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 358 matching lines @@
 
     this._manager._workers.set(workerId, this);
     WebInspector.targetManager.createTarget(title, WebInspector.Target.Type.ServiceWorker, this._connection, manager.target(), targetCreated.bind(this));
 
     /**
      * @param {?WebInspector.Target} target
      * @this {WebInspector.ServiceWorker}
      */
     function targetCreated(target)
     {
-        if (!target) {
+        if (!this._connection || !target) {
             this._manager._workers.delete(workerId);
             return;
         }
+        this._target = target;
         this._manager.dispatchEventToListeners(WebInspector.ServiceWorkerManager.Events.WorkersUpdated);
         target.runtimeAgent().run();
     }
 }
 
 WebInspector.ServiceWorker._lastAnonymousTargetId = 0;
 
 WebInspector.ServiceWorker.prototype = {
     /**
      * @return {string}
@@ skipping 19 matching lines @@
         return this._scope;
     },
 
     stop: function()
     {
         this._agent.stop(this._workerId);
     },
 
     _closeConnection: function()
     {
+        if (!this._target)

[dgozman, 2015/08/28 00:23:53]

Why this check? Should close connection anyway.

[pfeldman, 2015/08/28 17:17:23]

If the target is missing, it means connection did not open at the first place. I
should not be closing it, but I can remove the _connection field from this.
Which is not important since targetCreated is never called on it.

+            return;
         this._connection._close();
+        delete this._connection;
     }
 }
 
 /**
  * @constructor
  * @implements {ServiceWorkerAgent.Dispatcher}
  * @param {!WebInspector.ServiceWorkerManager} manager
  */
 WebInspector.ServiceWorkerDispatcher = function(manager)
 {
@@ skipping 375 matching lines @@
     },
 
     /**
      * @return {boolean}
      */
     _shouldBeRemoved: function()
     {
         return this._isRedundant() && (!this._hasErrorLog() || this._deleting);
     }
 }