Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318043003: DevTools: attempt to unflake http/tests/inspector/service-workers/service-workers-view.html. (Closed)

Created:
5 years, 3 months ago by pfeldman
Modified:
5 years, 3 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: attempt to unflake http/tests/inspector/service-workers/service-workers-view.html. BUG=521092 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201594

Patch Set 1 #

Total comments: 2

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M LayoutTests/inspector/sources/debugger/file-system-project-mapping.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/bindings/NetworkProject.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
pfeldman
5 years, 3 months ago (2015-08-27 18:21:13 UTC) #2
dgozman
https://codereview.chromium.org/1318043003/diff/1/Source/devtools/front_end/sdk/ServiceWorkerManager.js File Source/devtools/front_end/sdk/ServiceWorkerManager.js (right): https://codereview.chromium.org/1318043003/diff/1/Source/devtools/front_end/sdk/ServiceWorkerManager.js#newcode423 Source/devtools/front_end/sdk/ServiceWorkerManager.js:423: if (!this._target) Why this check? Should close connection anyway.
5 years, 3 months ago (2015-08-28 00:23:53 UTC) #3
pfeldman
https://codereview.chromium.org/1318043003/diff/1/Source/devtools/front_end/sdk/ServiceWorkerManager.js File Source/devtools/front_end/sdk/ServiceWorkerManager.js (right): https://codereview.chromium.org/1318043003/diff/1/Source/devtools/front_end/sdk/ServiceWorkerManager.js#newcode423 Source/devtools/front_end/sdk/ServiceWorkerManager.js:423: if (!this._target) If the target is missing, it means ...
5 years, 3 months ago (2015-08-28 17:17:23 UTC) #4
dgozman
lgtm
5 years, 3 months ago (2015-08-28 18:15:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318043003/1
5 years, 3 months ago (2015-08-28 18:16:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/38004)
5 years, 3 months ago (2015-08-28 18:19:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318043003/20001
5 years, 3 months ago (2015-08-31 19:29:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/100987)
5 years, 3 months ago (2015-08-31 23:11:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318043003/20001
5 years, 3 months ago (2015-09-02 01:40:39 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 01:45:44 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201594

Powered by Google App Engine
This is Rietveld 408576698