src/date.js - Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/date.js

Issue 1318043002: Native context: do not put public symbols and flags on the js builtins object. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix and rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/date.js

diff --git a/src/date.js b/src/date.js

index 44d2f4df1639044f19958d914c858bdc87760508..5df3afa98b7d5207c86c525f83070ad4c12919c3 100644

--- a/src/date.js

+++ b/src/date.js

@@ -21,6 +21,7 @@ var IsFinite;

var MathAbs;

var MathFloor;

var ToNumber;

+var toPrimitiveSymbol = utils.ImportNow("to_primitive_symbol");

var ToString;

utils.Import(function(from) {

@@ -847,8 +848,8 @@ utils.InstallFunctions(GlobalDate, DONT_ENUM, [

// Set up non-enumerable constructor property of the Date prototype object.

%AddNamedProperty(GlobalDate.prototype, "constructor", GlobalDate, DONT_ENUM);

-utils.SetFunctionName(DateToPrimitive, symbolToPrimitive);

-%AddNamedProperty(GlobalDate.prototype, symbolToPrimitive, DateToPrimitive,

+utils.SetFunctionName(DateToPrimitive, toPrimitiveSymbol);

+%AddNamedProperty(GlobalDate.prototype, toPrimitiveSymbol, DateToPrimitive,

DONT_ENUM | READ_ONLY);

// Set up non-enumerable functions of the Date prototype object and

« no previous file with comments | « src/collection-iterator.js ('k') | src/debug/mirrors.js » ('j') | no next file with comments »