Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318033002: Returning const ref instead of const value in CachedNetworkQuality::network_quality (Closed)

Created:
5 years, 3 months ago by shiva.jm
Modified:
5 years, 3 months ago
Reviewers:
bengr, eroman
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Returning const ref instead of const value in CachedNetworkQuality::network_quality BUG=393155 Committed: https://crrev.com/ad81bb89305859ac7a5186c13c076b8ec5848955 Cr-Commit-Position: refs/heads/master@{#346343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/base/network_quality_estimator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
shiva.jm
pls have a look.
5 years, 3 months ago (2015-08-28 04:07:05 UTC) #2
bengr
lgtm
5 years, 3 months ago (2015-08-28 20:30:24 UTC) #3
eroman
lgtm
5 years, 3 months ago (2015-08-28 20:53:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318033002/1
5 years, 3 months ago (2015-08-31 03:50:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 05:25:51 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 05:26:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ad81bb89305859ac7a5186c13c076b8ec5848955
Cr-Commit-Position: refs/heads/master@{#346343}

Powered by Google App Engine
This is Rietveld 408576698