Fix regression on x86 for "Fix compile error with Windows clang"

Fix regression on x86 for "Fix compile error with Windows clang"

R=thakis@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/5f520807ca93f0d95a1e72864f574f4ec19f6188

[Yoshisato Yanagisawa, 2015-08-27 04:29:44]

yyanagisawa@chromium.org changed reviewers:
+ thakis@chromium.org, wfh@chromium.org

[Yoshisato Yanagisawa, 2015-08-27 04:29:44]

Hi,

Let me fix the regression caused with "Fix compile error with Windows clang".
The patch made dump_syms.exe crash on x86.

wstring wprogram_string(program_string) does not work.

Let me use static cast instead, which seems to be valid:
https://msdn.microsoft.com/en-us/library/ta308ywy.aspx

[Nico, 2015-08-27 04:34:28]

not lgtm

This might work in practice, but it's not valid C++ as far as I know.
https://msdn.microsoft.com/en-us/library/ta308ywy.aspx looks like bad
documentation.

https://codereview.chromium.org/1318013002/diff/1/common/windows/pdb_source_l...
File common/windows/pdb_source_line_writer.cc (right):

https://codereview.chromium.org/1318013002/diff/1/common/windows/pdb_source_l...
common/windows/pdb_source_line_writer.cc:283: static_cast<wchar_t*>(name));
Does just saying name.m_bstr work here? It looks like that should be a WCHAR*
already, after looking at CComBSTR

[Yoshisato Yanagisawa, 2015-08-27 05:55:57]

thanks for the review.

https://codereview.chromium.org/1318013002/diff/1/common/windows/pdb_source_l...
File common/windows/pdb_source_line_writer.cc (right):

https://codereview.chromium.org/1318013002/diff/1/common/windows/pdb_source_l...
common/windows/pdb_source_line_writer.cc:283: static_cast<wchar_t*>(name));
On 2015/08/27 04:34:27, Nico wrote:
> Does just saying name.m_bstr work here? It looks like that should be a WCHAR*
> already, after looking at CComBSTR

thanks let me know it.
It seems work.  I thought it BSTR type, but with your comement I noticed BSTR
type is typedef of WCHAR*.

[Nico, 2015-08-27 06:06:41]

lgtm

[Will Harris, 2015-08-27 22:11:15]

On 2015/08/27 06:06:41, Nico wrote:
> lgtm

Yoshisato - do you want me to commit this to breakpad?

[Yoshisato Yanagisawa, 2015-08-31 01:55:35]

On 2015/08/27 22:11:15, Will Harris wrote:
> On 2015/08/27 06:06:41, Nico wrote:
> > lgtm
> 
> Yoshisato - do you want me to commit this to breakpad?

yes, please.

[Will Harris, 2015-09-03 23:39:01]

Committed patchset #2 (id:20001) manually as
5f520807ca93f0d95a1e72864f574f4ec19f6188 (presubmit successful).